TrinityCore#🧰・dev
Jul 11, 2026 · 06:08
screenshot from 12.0.7 TC, issue from 12.0.5- nearly TC
Jul 11, 2026 · 06:08
yes, but the code is much older
Jul 11, 2026 · 06:08
and the check
Jul 11, 2026 · 06:09
It is some leftover of an old check that needs to be fixed 😄
Jul 11, 2026 · 06:10
was thinking about it, cya after testing
Jul 11, 2026 · 06:11
The check was in there over 10 years ago already with 0xFFFF
Jul 11, 2026 · 06:12
don't think it makes sense to have that check in at all since there is a limiting client packet size check in worldsocket already
Jul 11, 2026 · 06:12
since whole data known - shold be data checked, not size, as i think...
Jul 11, 2026 · 06:16
yea, now seems account settings changed fine
Jul 11, 2026 · 06:18
i meen without that check
Jul 11, 2026 · 06:22
expected yea 😄
Jul 11, 2026 · 12:32
isn't that one specifically just to avoid large strings in server memory
Jul 11, 2026 · 12:35 (edited)
That would be a bad thing regarding the handling functionality tho. And can potentially break things (it does now with big packets)
Jul 11, 2026 · 12:41
thats the size of decompressed data, check still has to be there but with updated value
Jul 11, 2026 · 12:42
we dont do the "unchecked alloc size controlled by client" thing
Jul 11, 2026 · 12:44
Oh yea that is from the struct not from the buffer the size :lul:
Jul 11, 2026 · 12:44
But yea. Just set it to current max accepted packet size?
Jul 11, 2026 · 12:45
well about that
Jul 11, 2026 · 12:45
that IS the max accepted packet size
Jul 11, 2026 · 12:46
we only have an exception for CMSG_HOTFIX_REQUEST
Jul 11, 2026 · 12:50
0x100000 is no?
Jul 11, 2026 · 12:50
thats for hotfix
Jul 11, 2026 · 12:50
0x10000 for everything else
Jul 11, 2026 · 12:51
Should not look on phone:lul:
Jul 12, 2026 · 19:08
I tried to implement pet battles, even if just in a basic/primitive way. I pulled logs from the official server, and I think I implemented all the structures as they should be, but even the pet battle window doesn't open. Has anyone dug into this before? Maybe you could give me some pointers?
Jul 12, 2026 · 21:02
Pet Battles are SceneScript I believe, for the Pet Battle UI to open you need to send a SceneScript packet
Jul 12, 2026 · 23:03
Indeed they are handled as SceneObject, you have to send the SMSG_PET_BATTLE packets, there is one for initialize (spawns the two teams, trap and slot data for the fight), finalize location (makes pets move to the front vs back row), first round, round result, replacements, request failed, final round and finished (despawns everything)
Jul 12, 2026 · 23:04
there is also SMSG_SCENE_OBJECT_PET_BATTLE but those are just older versions of the above and not needed to make it work
Jul 12, 2026 · 23:06
look into their structure, they pretty much reveal all of the backing records
Jul 12, 2026 · 23:09
i believe you also need to send a SMSG_UPDATE_OBJECT with the scene info
Jul 13, 2026 · 06:41
Here's the interesting part: I'm sending the packets with the exact opcodes from the packet parser and sniffed dump. They're 1:1 identical to what the official server sends, but for some reason nothing starts on my server.
Jul 13, 2026 · 11:38 (edited)
try changing your phase, there was one for pet battling afaik.
Edit: nvm theres only one for the cloud serpent hatchling and stadium
Jul 14, 2026 · 18:05
Jul 14, 2026 · 18:05
new mount, i wonder if Shauren will find a bug on this one too :5925peperain:
Jul 14, 2026 · 18:06
well... technically its a bug
Jul 14, 2026 · 18:06
so yes
Jul 14, 2026 · 18:06
i can
Jul 14, 2026 · 18:06
:KEKW:
Jul 14, 2026 · 18:06
I knew it
Jul 14, 2026 · 18:09
sassy
Jul 14, 2026 · 18:09
:thinkge:
Jul 14, 2026 · 21:27
that scientifically accurate butterfly mount looks really ugly
Jul 14, 2026 · 22:08
really? i find it precious
Jul 14, 2026 · 22:35
Jul 15, 2026 · 00:39
that's a lot ai stuff PRs lately
Jul 15, 2026 · 00:39
:thinkge:
Jul 15, 2026 · 05:17
@Shauren TimeToTargetUnk1205Curve seems to be related to MorphCurveId (not sure if any other too), without this field being set to duration, the client doesn't render morphcurves at all
Jul 15, 2026 · 05:17
it jumps to its target radius directly
Jul 15, 2026 · 05:19
maybe they finally decoupled scale and shape clocks on the client
Jul 15, 2026 · 18:55
yo guys i have a question, is there a plan to support the 5.5.4 MoP classic client or any other classic clients? would love to sneak in there without paying for a sub just for a bit or is that intentionaly skipped content?
Jul 15, 2026 · 18:56
i saw WOTLK and cata was done as branch but found nothing about the state of panda
Jul 15, 2026 · 18:56
mop classic is not planned
Jul 15, 2026 · 18:56
Wotlk and cata are also dead branches
Jul 15, 2026 · 19:41
fuck 😄 would've been fun 😄
Jul 15, 2026 · 19:50
lack of interests/contribution from the community
and also we are just a handfull of free time Devs... so we cant maintain 1000 different versions
Jul 15, 2026 · 19:50
Sooo yeah 😄
Jul 15, 2026 · 20:48
If you're expecting a free lunch then the only branch that comes even remotely close is 3.3.5
Jul 15, 2026 · 20:49
all the rest (except to some extent TCPP) is basically empty sandboxes
Jul 15, 2026 · 21:20
oh yeah more i wasnt expecting at all for 5.5.4 not a working state of course
Jul 15, 2026 · 23:04
master branch has several quests into mop intro implemented
Jul 15, 2026 · 23:05
but that's pretty much it
Jul 15, 2026 · 23:05
iirc it was Meji implementing them
Jul 15, 2026 · 23:05
maybe a boss here or there, or even instances (not looking at the rep)
Jul 16, 2026 · 00:47
I guess my only need was to basically create a char and load it into the classic client but i guess i just go and get a sub 😄 i wanted to see the HD texturepack of MOP classic 😄
Jul 16, 2026 · 00:48
making myself a HD patch for MOP 5.4.8 haha
Jul 16, 2026 · 05:20
The HD texturs are just AI upscaled so you can basically craft them on your own machine
Jul 16, 2026 · 16:54
Jul 16, 2026 · 16:54
so new to the patch we finally get count on tooltips
Jul 17, 2026 · 13:18
pretty sure that info has been in DBCs for years
Jul 17, 2026 · 13:19
:What:
Jul 17, 2026 · 13:19
No
Jul 17, 2026 · 13:19
yes
Jul 17, 2026 · 13:20
Then tell me which db2 😄
Jul 17, 2026 · 13:20
Because I am fairly certain that M+ % count was not "public" before
Jul 17, 2026 · 13:20
criteriatree
Jul 17, 2026 · 13:20
And if it is then I am sorely mistaken 😄
Jul 17, 2026 · 13:22
and scenariostep
Jul 17, 2026 · 13:22 (edited)
the enemy % for specific mobs is surely not in db2?
Jul 17, 2026 · 13:22
criteria tree, scenariostep, enemy forces for normal and teeming
Jul 17, 2026 · 13:23
this is for nexus point xenas
Jul 17, 2026 · 13:23
it works exactly the same way as progressbar quest objectives
Jul 17, 2026 · 13:23
i forgot the query
Jul 17, 2026 · 13:23
but i dumped it
Jul 17, 2026 · 13:25
Parent has total # and the steps have the contribution per creature id
Jul 17, 2026 · 13:25
pre-midnight it was also accessible from lua but then they removed it for whatever reason
Jul 17, 2026 · 13:25
Interesting, okay 😄 Didn't think that data would all be client sided
Jul 17, 2026 · 13:27
Is teeming still an affix even?
Jul 17, 2026 · 13:28
no
Jul 17, 2026 · 13:29
Unfortunate
Jul 17, 2026 · 13:31
they got rid of all the affixes that made people alter routes or just skip entire weeks
Jul 17, 2026 · 13:32
now its [xalatath affix (1 of 4, rotating)] + tyrannical/fortified at +idk what level, then the_other_of_tyrannical/foritifed at some higher level
Jul 17, 2026 · 13:33
and then at +12 xalatath affix goes away
Jul 17, 2026 · 13:34
lol ok
Jul 17, 2026 · 13:35
its not that weird, that affix is [do thing for a buff]
Jul 17, 2026 · 13:36
Yeah I played a bit at the start of midnight, I just don’t like seasonal affixes, I absolutely hated incorporeal (the one you have to dispel or cc mobs)
Jul 17, 2026 · 17:44
it has always been public
Jul 17, 2026 · 17:46
as Shauren said, they restricted addons from accessing the info from LUA, just to expose it publicly directly
Jul 17, 2026 · 17:46
choices
Jul 17, 2026 · 17:47
i actually didnt check if they removed it from lua api
Jul 17, 2026 · 17:47
or it just broke because tooltips are secret in dungeons/combat